[BUG SUB] cannot compile silc-toolkit on Solaris Nevada - silc-toolkit (fwd)

[Pekka Riikonen]

---------- Forwarded message ----------
Date: Mon, 11 Sep 2006 15:47:35 +0200
From: Vladimir Kotal <vlada at devnull.cz>
To: Pekka Riikonen <priikone at iki.fi>
Cc: Vladimir Kotal <vlada at devnull.cz>
Subject: Re: [BUG SUB] cannot compile silc-toolkit on Solaris Nevada -
     silc-toolkit

On Mon, Sep 11, 2006 at 02:16:15PM +0200, Pekka Riikonen wrote:
> On Mon, 11 Sep 2006, Vladimir Kotal wrote:
>
> : Operating System: Solaris Nevada build 36
> : Installation: source
> : Severity: major
> :
> : Description:
> :
> : Due to Makefiles in apps/irssi/src/perl/common it is not possible to compile silc-toolkit.
> :
> : you can get the error log here:
> : http://techie.devnull.cz/public/silc-toolkit-err-nevada.log
> :
> : The Makefile does not honor CC setting by configure script at all !
> :
> : It also contains hard-coded \'cc\' value.
> :
> Is your make GNU make?  GNU make is probably required to compile the
> apps/irssi/ portion of the Toolkit... Currently only SILC Server package
> compiles with practically any make, others require GNU make.
>

I have revisited the issue once more and must say that the use of
makefiles in apps/irssi/src/perl/ is really horrible piece of
unportable makefile example.

- it does not honor @CC@ at all (for both CC and LD)
- it sets unportable optimizations (OPTIMIZE contents are just plain wrong
on my system)

This is not only case of apps/irssi/src/perl/common/Makefile* but also

apps/irssi/src/perl/ui/Makefile*
apps/irssi/src/perl/textui/Makefile*
apps/irssi/src/perl/silc/Makefile*

The Makefile.PL.in need to look like this:

WriteMakefile('NAME' => 'Irssi::UI',
               'LIBS' => '',
               'OBJECT' => '$(O_FILES)',
               'CC' => '@CC@',
               'LD' => '@CC@',
...

After fixing the Makefile.PL.in files and rerunning configure and running
gmake as:
    gmake CCCDLFLAGS="-fPIC" OPTIMIZE="" LD=gcc

I was able to compile silc-toolkit on Solaris Nevada.

Clearly, the makefiles need to be fixed.


v.