[BUG SUB] silc toolkit contains gcc-isims and CFLAGS when it shouldn\'t - silc toolkit

[Torrey McMahon]

Pekka Riikonen wrote:
> : Software: silc toolkit
> : Version: 1.1
> : Operating System: Solaris
> : Installation: source
> : Severity: non-critical
> : 
> : First, CFLAGS has -g -O appended to it no matter what I set. This is 
> : broken. CFLAGS should be left blank and set by the user if they want 
> : them set. I already set some debug and optimization flags and this 
> : overrides them.
> : 
> The -g is used with all compilers, not just with GCC, so that even 
> non-debug version can be debugged for bugs if needed.  The CFLAGS can be 
> defined by user but the ./configure does remove all -O options from it 
> because we want to control optimizations (it should preserve other user 
> specified options).  Some parts of the code are compiled with different 
> optimization levels.  If these options don't do with your compiler what we 
> expect them to do, that is the real bug, and I'd appreciate knowing what 
> compiler/OS you were using (what configure said you were using) so that we 
> can set specific case for that.
>   

Solaris and Sun's compilers. You'd want to set -xO[N] where N is between 
1 and 5. However, with the Sun compilers the options are parsed first to 
last so if I set my CFLAGS to max optimization and then the configure 
script comes in and decides to put "-g -xO2" at the end it overrides 
everything I just set.

I'd suggest providing a note in the readme for suggested optimization 
levels and let the person doing the build decide what they want to use.

> : Second, MATH_CFLAGS is set and used in some locations and its gcc 
> : specific. That should either be an option or env variable to set at 
> : configure time.
> : 
> That's one of the parts we want to compile and optimize differently, hence 
> the MATH_CFLAGS.  Even if I'd add support for MATH_CFLAGS environment 
> variable we'd still set our default, mandatory, options for all compilers.

The options you're using are gcc dependent and cause lots of error 
messages when using Sun's compiler.