[PATCH] Fix for double initialization of silc plugin in irssi (resulting in duplication of "action" messsages)

[Skywing]

I was using the latest 1.1.4 (grabbed the source distribution yesterday and built from there in fact)...

Furthermore, I'm not entirely sure about the explanation that it's a makefile issue.  The problem seems to be that both fe_common_silc_init() and fe_silc_init() call silc_init(), which does not handle being called twice correctly.  Or am I missing why you're saying it's a makefile problem?  (Will freely admit that I'm not too terribly familiar with this codebase.  The message duplication problem stems from the fact that calling silc_init() twice calls fe_silc_messages_init() twice, which registers for signals twice, meaning that certain messages are processed twice and thus, for instance, the silc message action signal writes the emote to the screen two times.

Or is there some other circumstance that I am missing here?

- S

-----Original Message-----
From: Pekka Riikonen [mailto:priikone at iki.fi]
Sent: Thursday, March 27, 2008 4:03 AM
To: Jochen Eisinger
Cc: Skywing; silc-devel at lists.silcnet.org
Subject: Re: [PATCH] Fix for double initialization of silc plugin in irssi (resulting in duplication of "action" messsages)

On Thu, 27 Mar 2008, Jochen Eisinger wrote:

: Date: Thu, 27 Mar 2008 07:57:44 +0100
: From: Jochen Eisinger <jochen at penguin-breeder.org>
: To: Skywing <Skywing at valhallalegends.com>
: Cc: "silc-devel at lists.silcnet.org" <silc-devel at lists.silcnet.org>
: Subject: Re: [PATCH] Fix for double initialization of silc plugin in irssi
:     (resulting in duplication of "action" messsages)
:
: Hi,
:
: this is already fixed in git (the problem is in the makefile which
: installs the module twice)
:
And surely should be fixed in latest 1.1.4.

        Pekka
________________________________________________________________________
 Pekka Riikonen                                 priikone at silcnet.org
 Secure Internet Live Conferencing (SILC)       http://silcnet.org/